-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] fix channel units for EEG and iEEG #124
[WIP] fix channel units for EEG and iEEG #124
Conversation
- remove test for single set file as it does not support preload=False - check raw has not been cropped
@sappelhoff I had something simpler in mind. All you needed to do was: $ git fetch mainak refactor_raw_to_bids:refactor_raw_to_bids
$ git checkout -b channel_units And yep, if you need to update your branch, you would just do: $ git checkout refactor_raw_to_bids
$ git pull mainak refactor_raw_to_bids
$ git checkout channel_units
$ git rebase refactor_raw_to_bids you could probably also do: $ git checkout channel_units
$ git pull --rebase mainak refactor_raw_to_bids |
awesome, thanks @jasmainak! ... this is much better and I got it now :-) you only missed a step after
so that I check out your changes and branch off them, instead of branching off the branch from where I fetched your |
Oh yes you are right! |
closes #81
Using MNE-Python Master (or soon 0.17), I will be able to fix this for BrainVision and EDF (the primary formats both for EEG and iEEG) ... and probably also for BDF and EEGLAB.
I will not be able to fix it for
@jasmainak is this what you meant by basing the PR off your #106? It's the first time I'm doing something like this.
My steps:
git remote add mainak https://github.com/jasmainak/mne-bids
git fetch mainak
git checkout -b mainak/refactor_raw_to_bids
git pull --rebase mainak refactor_raw_to_bids
git push --set-upstream origin mainak/refactor_raw_to_bids
I think I will be able to easily get all of Mainak's updates by periodically using
git pull mainak refactor_raw_to_bids
... potentially with a--rebase
flag ... so that's nice. What I don't like is that I couldn't choose my own name for this branchPlease correct me if that was wrong.